Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270653

Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets

Show all headers | View raw

Hi Jason,

On Mon, Nov 16, 2015, at 21:58, Jason A. Donenfeld wrote:
> Hi David,
> 
> On Mon, Nov 16, 2015 at 9:32 PM, David Miller <davem@davemloft.net>
> wrote:
> > Network device driver transmit executes with software interrupts
> > disabled.
> >
> > Therefore on x86, you cannot use the FPU.
> 
> That is extremely problematic for me. Is there a way to make this not
> so? A driver flag that would allow this?
> 
> Also - how come it irq_fpu_usable() is true when using TCP but not
> when using UDP?
> 
> Further, irq_fpu_usable() doesn't only check for interrupts. There are
> two other conditions that allow the FPU's usage, from
> arch/x86/kernel/fpu/core.c:
> 
> bool irq_fpu_usable(void)
> {
>         return !in_interrupt() ||
>                 interrupted_user_mode() ||
>                 interrupted_kernel_fpu_idle();
> }

Use the irqsoff tracer to find the problematic functions which disable
interrupts and try to work around it in case of UDP. This could benefit
the whole stack.

Bye,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

irq_fpu_usable() is false in ndo_start_xmit() for UDP packets "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-16 21:00 +0100
  Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets David Miller <davem@davemloft.net> - 2015-11-16 21:40 +0100
    Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-16 22:00 +0100
      Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets David Miller <davem@davemloft.net> - 2015-11-16 22:20 +0100
        Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-16 22:30 +0100
          Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-16 22:40 +0100
          Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets David Miller <davem@davemloft.net> - 2015-11-16 22:40 +0100
      Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-11-16 23:30 +0100
        Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-17 01:00 +0100
          Re: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-17 01:10 +0100
    RE: irq_fpu_usable() is false in ndo_start_xmit() for UDP packets David Laight <David.Laight@ACULAB.COM> - 2015-11-17 13:40 +0100

csiph-web