Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269694

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

Show all headers | View raw

On 15/11/2015 11:04, Or Gerlitz wrote:
> On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg
> <sagig@dev.mellanox.co.il> wrote:
>> Or is correct,
>>
>> I have attempted to convert iser to use blk_iopoll in the past, however
>> I've seen inconsistent performance and latency skews (comparing to
>> tasklets iser is using today). This was manifested in IOPs test cases
>> where I ran multiple threads with higher queue-depth and not in
>> sanitized pure latency (QD=1) test cases. Unfortunately I didn't have
>> the time to pick it up since.
>>
>> I do have every intention of testing it again with this. If it still
>> exist we will need to find the root-cause of it before converting
>> drivers to use it.
>
> Good, this way (inconsistent performance and latency skews) or another
> (all shines up) -- please
> let us know your findings, best through commenting within V > 0 the
> cover letter posts of this series
>

Hi Or & Co,

I ran some tests on the iser code with this patchset applied.
I can confirm that I did not see any performance degradations.
summary (on my test servers):
1  LUN:   ~530K  (IOPs)
2  LUNs:  ~1080K (IOPs)
4  LUNs:  ~1350K (IOPs)
8  LUNs:  ~1930K (IOPs)
16 LUns:  ~2250K (IOPs)

These results are true both for tasklet and iopoll.

So, I don't have anything smart to say here, the IO
stack (block, scsi) has gone through major changes since
the last time I looked into this, so it'll be pretty hard to figure
out what was the root cause back then...

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

add a proper completion queue abstraction Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100
  [PATCH 7/9] IB/iser: Use a dedicated descriptor for login Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100
  [PATCH 1/9] move blk_iopoll to limit and make it generally available Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100
    Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available Or Gerlitz <gerlitz.or@gmail.com> - 2015-11-13 16:30 +0100
      Re: [PATCH 1/9] move blk_iopoll to limit and make it generally  available Christoph Hellwig <hch@lst.de> - 2015-11-14 08:10 +0100
        Re: [PATCH 1/9] move blk_iopoll to limit and make it generally  available Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-15 09:50 +0100
          Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available Or Gerlitz <gerlitz.or@gmail.com> - 2015-11-15 10:10 +0100
            Re: [PATCH 1/9] move blk_iopoll to limit and make it generally  available Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-15 14:20 +0100
          Re: [PATCH 1/9] move blk_iopoll to limit and make it generally  available Christoph Hellwig <hch@lst.de> - 2015-11-15 14:00 +0100
    Re: [PATCH 1/9] move blk_iopoll to limit and make it generally  available Christoph Hellwig <hch@lst.de> - 2015-11-14 08:10 +0100
      Re: [PATCH 1/9] move blk_iopoll to limit and make it generally  available Christoph Hellwig <hch@lst.de> - 2015-11-18 15:00 +0100
  [PATCH 6/9] srp: use the new CQ API Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100
    Re: [PATCH 6/9] srp: use the new CQ API Christoph Hellwig <hch@lst.de> - 2015-11-18 15:10 +0100
  [PATCH 4/9] srpt: chain RDMA READ/WRITE requests Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100
    Re: [PATCH 4/9] srpt: chain RDMA READ/WRITE requests Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-18 10:20 +0100
      Re: [PATCH 4/9] srpt: chain RDMA READ/WRITE requests Christoph Hellwig <hch@lst.de> - 2015-11-20 11:30 +0100
    Re: [PATCH 4/9] srpt: chain RDMA READ/WRITE requests Christoph Hellwig <hch@lst.de> - 2015-11-18 15:10 +0100
  [PATCH 9/9] IB/iser: Convert to CQ abstraction Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100
  [PATCH 8/9] IB/iser: Use helper for container_of Christoph Hellwig <hch@lst.de> - 2015-11-13 15:00 +0100

csiph-web