Re: [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro
Date	2015-11-15 12:20 +0100
Message-ID	<qv3vH-DB-1@gated-at.bofh.it> (permalink)
References	<qsVCi-7yE-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/11/15 14:26, Nizam Haider wrote:
> Replaces bit shifting on 1 with the BIT(x) macro
> 
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
Applied to the togreg branch of iio.git - guess I'm going to start
getting the autobuilder warnings shortly!

Will be pushed out as testing for the autobuilders to play with it.

Jonathan
> ---
>  drivers/staging/iio/adc/mxs-lradc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index d997d9c..5f1375c 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -324,7 +324,7 @@ struct mxs_lradc {
>  #define	LRADC_DELAY_TRIGGER(x) \
>  				(((x) << LRADC_DELAY_TRIGGER_LRADCS_OFFSET) & \
>  				LRADC_DELAY_TRIGGER_LRADCS_MASK)
> -#define	LRADC_DELAY_KICK			(1 << 20)
> +#define	LRADC_DELAY_KICK			BIT(20)
>  #define	LRADC_DELAY_TRIGGER_DELAYS_MASK		(0xf << 16)
>  #define	LRADC_DELAY_TRIGGER_DELAYS_OFFSET	16
>  #define	LRADC_DELAY_TRIGGER_DELAYS(x) \
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro Nizam Haider <nizamhaider786@gmail.com> - 2015-11-09 15:30 +0100
  Re: [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro Jonathan Cameron <jic23@kernel.org> - 2015-11-15 12:20 +0100

csiph-web