Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1269667

Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()

From Hans Ulli Kroll <ulli.kroll@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()
Date 2015-11-15 12:00 +0100
Message-ID <qv3cm-gr-17@gated-at.bofh.it> (permalink)
References <qut8T-2FM-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 14 Nov 2015, Nizam Haider wrote:

> The driver core clears the driver data to NULL after device_release
> or on probe failure
> 
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
> ---
>  drivers/rtc/rtc-gemini.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
> index e841846..f46b6d4 100644
> --- a/drivers/rtc/rtc-gemini.c
> +++ b/drivers/rtc/rtc-gemini.c
> @@ -156,7 +156,6 @@ static int gemini_rtc_remove(struct platform_device *pdev)
>  	struct gemini_rtc *rtc = platform_get_drvdata(pdev);
>  
>  	rtc_device_unregister(rtc->rtc_dev);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	return 0;
>  }
> -- 
> 1.8.1.4
> 
> 

Acked-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata() Nizam Haider <nizamhaider786@gmail.com> - 2015-11-13 21:30 +0100
  Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary  platform_set_drvdata() Hans Ulli Kroll <ulli.kroll@gmail.com> - 2015-11-15 12:00 +0100

csiph-web