Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1269685

[PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn

From Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups linux.kernel
Subject [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn
Date 2015-11-15 12:50 +0100
Message-ID <qv3YK-Sx-21@gated-at.bofh.it> (permalink)
References <qv3YK-Sx-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


If max_pfn is not initialized, the block layer may use wrong DMA masks.

Replace open-coded shifts by PFN_DOWN() while we're at it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Compile-tested only.
---
 arch/m68k/kernel/setup_no.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 88c27d94a7214c95..29b44e69f0f47375 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p)
 	 * Give all the memory to the bootmap allocator, tell it to put the
 	 * boot mem_map at the start of memory.
 	 */
+	min_low_pfn = PFN_DOWN(memory_start);
+	max_pfn = max_low_pfn = PFN_DOWN(memory_end);
+
 	bootmap_size = init_bootmem_node(
 			NODE_DATA(0),
-			memory_start >> PAGE_SHIFT, /* map goes here */
-			PAGE_OFFSET >> PAGE_SHIFT,	/* 0 on coldfire */
-			memory_end >> PAGE_SHIFT);
+			min_low_pfn,		/* map goes here */
+			PFN_DOWN(PAGE_OFFSET),	/* 0 on coldfire */
+			max_pfn);
 	/*
 	 * Free the usable memory, we have to make sure we do not free
 	 * the bootmem bitmap so we then reserve it after freeing it :-)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] m68k/mm: Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-15 12:50 +0100
  [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-15 12:50 +0100
    Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and  {min,max}_low_pfn Greg Ungerer <gerg@uclinux.org> - 2015-11-16 13:20 +0100
      Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-16 14:10 +0100
        Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and  {min,max}_low_pfn Greg Ungerer <gerg@uclinux.org> - 2015-11-17 00:50 +0100
    Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and  {min,max}_low_pfn Greg Ungerer <gerg@uclinux.org> - 2015-11-17 01:00 +0100
      Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-22 11:40 +0100
  Re: [PATCH 0/4] m68k/mm: Add missing initialization of max_pfn and  {min,max}_low_pfn Greg Ungerer <gerg@uclinux.org> - 2015-11-17 01:20 +0100

csiph-web