Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1269676
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Nizam Haider <nizamhaider786@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area |
| Date | Sun, 15 Nov 2015 12:40:01 +0100 |
| Message-ID | <qv3P3-Ly-7@gated-at.bofh.it> (permalink) |
| References | <quz4C-6oN-3@gated-at.bofh.it> <quFjH-2bY-1@gated-at.bofh.it> <quMOd-6Vd-3@gated-at.bofh.it> |
| X-Original-To | Jonathan Cameron <jic23@kernel.org> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=W47r/C3Qaf0uUsgeElZ0Q6N6HQFpjB6E4To4aPc4Q8s=; b=Wq+UbkGXjSkALxTD3ImZ/WqYbPTFMN/b18/CYgKQER06/jc/RiGSD5quifqRQe1u3K qWFNdQaX/1+MFi45iat9rfLh1wHuDw8qNM1DvFUzSi8PIFPfm/d65DadzNzP044m1Sgm YmBtPnfRc9pd5TDWJLkYrJAuG1rE8Y9sYNJxjd+kIekk45Skq228aqmfNQoMWywvLcPI 2AdoAAc0M8AcmIvGM1onEYd9CJRSsCwA5dUisqL5GReKA6MzPviASQgBkMFjAon6EawO GwSCipju8yCJxFa33Vn38X0j99rjHIAGycdOaItDT/Vpvbi0lop7mWQJ7z49Tlyo53F+ r/9g== |
| X-Received | by 10.68.203.1 with SMTP id km1mr1022675pbc.19.1447587333126; Sun, 15 Nov 2015 03:35:33 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 56 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Lars-Peter Clausen <lars@metafoo.de>, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nizam Haider <nijamh@cdac.in> |
| X-Original-Date | Sun, 15 Nov 2015 17:05:03 +0530 |
| X-Original-Message-ID | <20151115113503.GA18884@suse.site> |
| X-Original-References | <1447469041-5751-1-git-send-email-nizamhaider786@gmail.com> <5646FEC7.5050600@metafoo.de> <56476DAC.6030903@kernel.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1269676 |
Show key headers only | View raw
On Sat, Nov 14, 2015 at 05:21:48PM +0000, Jonathan Cameron wrote: > On 14/11/15 09:28, Lars-Peter Clausen wrote: > > On 11/14/2015 03:44 AM, Nizam Haider wrote: > >> Fix simple typo in comments > >> > >> Signed-off-by: Nizam Haider <nijamh@cdac.in> > > > > Thanks for the patch. > > > >> --- > >> drivers/staging/iio/iio_simple_dummy_buffer.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c > >> index cf44a6f..c8f889b 100644 > >> --- a/drivers/staging/iio/iio_simple_dummy_buffer.c > >> +++ b/drivers/staging/iio/iio_simple_dummy_buffer.c > >> @@ -64,7 +64,7 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p) > >> * software scans: can be considered to be random access > >> * so efficient reading is just a case of minimal bus > >> * transactions. > >> - * software culled hardware scans: > >> + * software called hardware scans: > > > > I don't think that's a typo. The non-patched version makes a lot more sense > > then the patched vesion. > Yup, that's me using some 'more unusual' English terminology, Perhaps the word > 'dropped' would be clearer. > > Also, that comment is now a little misleading as it is unusual / undesirable Yes it is misleading now, non-patched version makes a lot more sense then patched version. but because of unusual english, should i use dropped and to send new patch or to just leave it. (it would be bit easy to understand in first shot with "dropped".) Nizam > to now do this in an individual driver. The core demux code should take care > of it. > > Hmm.. I'll make a note to reread the comments in that driver and see if any > others could do with a refresh. > > Jonathan > > > >> * occasionally a driver may process the nearest hardware > >> * scan to avoid storing elements that are not desired. This > >> * is the fiddliest option by far. > >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area Nizam Haider <nizamhaider786@gmail.com> - 2015-11-14 03:50 +0100
Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area Lars-Peter Clausen <lars@metafoo.de> - 2015-11-14 10:30 +0100
Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area Jonathan Cameron <jic23@kernel.org> - 2015-11-14 18:30 +0100
Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area Nizam Haider <nizamhaider786@gmail.com> - 2015-11-15 12:40 +0100
Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area Jonathan Cameron <jic23@kernel.org> - 2015-11-15 13:30 +0100
csiph-web