Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269347

Re: [PATCH] mm: get rid of __alloc_pages_high_priority

Show key headers only | View raw

On Fri, 13 Nov 2015, Michal Hocko wrote:

> > > Hi,
> > > I think that this is more a cleanup than any functional change. We
> > > are rarely screwed so much that __alloc_pages_high_priority would
> > > fail. Yet I think that __alloc_pages_high_priority is obscuring the
> > > overal intention more than it is helpful. Another motivation is to
> > > reduce wait_iff_congested call to a single one in the allocator. I plan
> > > to do other changes in that area and get rid of it altogether.
> > 
> > I think it's a combination of a cleanup (the inlining of 
> > __alloc_pages_high_priority) and a functional change (no longer looping 
> > infinitely around a get_page_from_freelist() call).  I'd suggest doing the 
> > inlining in one patch and then the reworking of __GFP_NOFAIL when 
> > ALLOC_NO_WATERMARKS fails just so we could easily revert the latter if 
> > necessary.
> 
> I can split it up if this is really preferable of course.

I think it's preferable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: get rid of __alloc_pages_high_priority mhocko@kernel.org - 2015-11-12 17:00 +0100
  Re: [PATCH] mm: get rid of __alloc_pages_high_priority David Rientjes <rientjes@google.com> - 2015-11-12 21:50 +0100
    Re: [PATCH] mm: get rid of __alloc_pages_high_priority Michal Hocko <mhocko@kernel.org> - 2015-11-13 10:20 +0100
      Re: [PATCH] mm: get rid of __alloc_pages_high_priority David Rientjes <rientjes@google.com> - 2015-11-13 23:40 +0100
  Re: [PATCH] mm: get rid of __alloc_pages_high_priority Mel Gorman <mgorman@suse.de> - 2015-11-13 11:20 +0100

csiph-web