Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269200

Re: [PATCH 2/4] timer: relax tick stop in idle entry

Show all headers | View raw

On Fri, 13 Nov 2015, Jacob Pan wrote:

> Upon entering idle, we can turn off tick if the next timeout
> is exactly one tick away. Otherwise, we could enter inner idle loop
> with tick still enabled, without resched set, the tick will continue
> during idle therefore less optimal in terms of energy savings.

This does not make any sense at all. 

next_tick is the next required tick event. If it's exactly ONE tick
away why should we go through the hassle of stopping it? Just to
cancel the timer and then set it to the same value again? Oh well.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] timer: relax tick stop in idle entry Jacob Pan <jacob.jun.pan@linux.intel.com> - 2015-11-13 21:00 +0100
  Re: [PATCH 2/4] timer: relax tick stop in idle entry Thomas Gleixner <tglx@linutronix.de> - 2015-11-13 21:30 +0100
    Re: [PATCH 2/4] timer: relax tick stop in idle entry Jacob Pan <jacob.jun.pan@linux.intel.com> - 2015-11-13 23:30 +0100

csiph-web