Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269050

Re: [PATCH v8 1/4] Documentation: dt-bindings: Describe SROMc configuration

Show all headers | View raw

On Thu, Nov 12, 2015 at 7:12 AM, Pavel Fedin <p.fedin@samsung.com> wrote:
> Add documentation for new subnode properties, allowing bank configuration.
> Based on u-boot implementation, but heavily reworked.
>
> Also, fix size of SROMc mapping in the example.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Acked-by: Rob Herring <robh@kernel.org>

One nit below.

>                 compatible = "samsung,exynos-srom";
> -               reg = <0x12570000 0x10>;
> +               reg = <0x12570000 0x14>;
> +
> +               ethernet@3 {

This should actually be "ethernet@3,0"

Fields (not cells) in the unit address should be separated by commas.

> +                       compatible = "smsc,lan9115";
> +                       reg = <3 0 0x10000>;       // Bank 3, offset = 0
> +                       phy-mode = "mii";
> +                       interrupt-parent = <&gpx0>;
> +                       interrupts = <5 8>;
> +                       reg-io-width = <2>;
> +                       smsc,irq-push-pull;
> +                       smsc,force-internal-phy;
> +
> +                       samsung,srom-page-mode = <1>;
> +                       samsung,srom-timing = <9 12 1 9 1 1>;
> +               };
>         };
> --
> 2.4.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 0/4] Exynos SROMc configuration and Ethernet support for  SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-11-12 14:20 +0100
  [PATCH v8 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin <p.fedin@samsung.com> - 2015-11-12 14:20 +0100
  [PATCH v8 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin <p.fedin@samsung.com> - 2015-11-12 14:20 +0100
  [PATCH v8 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin <p.fedin@samsung.com> - 2015-11-12 14:20 +0100
    Re: [PATCH v8 1/4] Documentation: dt-bindings: Describe SROMc configuration Rob Herring <robh+dt@kernel.org> - 2015-11-13 17:10 +0100
  [PATCH v8 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-11-12 14:20 +0100

csiph-web