Re: [PATCH 02/12] perf probe: Clear probe_trace_event when add_probe_trace_event() fails

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/12] perf probe: Clear probe_trace_event when add_probe_trace_event() fails
Date	2015-11-13 17:00 +0100
Message-ID	<quoVA-8kr-13@gated-at.bofh.it> (permalink)
References	<qulEm-6kY-9@gated-at.bofh.it> <qulO4-6pf-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Nov 13, 2015 at 12:29:11PM +0000, Wang Nan escreveu:
> When probe with glob, error in add_probe_trace_event() won't be passed
> to debuginfo__find_trace_events() because it whould be modified by
> probe_point_search_cb(). It causes segfault if perf failed to find
> argument for one probing point matched by the glob. For example:

I applied the first two patches in this series, after testing them by
following the before/after instructions, thank you for providing it!

I'm now going from patch 6 onwards, just FYI.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 00/12] perf tools: bpf: Improve BPF program ability Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:30 +0100
  [PATCH 08/12] perf tools: Compile dwarf-regs.c if CONFIG_BPF_PROLOGUE is on Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 07/12] perf tools: Add BPF_PROLOGUE config options for further patches Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 09/12] perf tools: Add prologue for BPF programs for fetching arguments Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 06/12] bpf tools: Load a program with different instances using preprocessor Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 03/12] perf tools: Allow BPF program attach to uprobe events Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
    Re: [PATCH 03/12] perf tools: Allow BPF program attach to uprobe  events Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 16:40 +0100
  [PATCH 11/12] perf test: Test BPF prologue Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 04/12] perf tools: Allow BPF program attach to modules Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
    Re: [PATCH 04/12] perf tools: Allow BPF program attach to modules Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 16:50 +0100
  [PATCH 10/12] perf tools: Generate prologue for BPF programs Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 05/12] perf tools: Allow BPF program config probing options Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
    Re: [PATCH 05/12] perf tools: Allow BPF program config probing  options Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 16:50 +0100
      Re: [PATCH 05/12] perf tools: Allow BPF program config probing options "Wangnan (F)" <wangnan0@huawei.com> - 2015-11-16 10:20 +0100
  [PATCH 01/12] perf probe: Fix memory leaking on faiulre by clearing all probe_trace_events Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
  [PATCH 02/12] perf probe: Clear probe_trace_event when add_probe_trace_event() fails Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100
    Re: [PATCH 02/12] perf probe: Clear probe_trace_event when  add_probe_trace_event() fails Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 17:00 +0100
  [PATCH 12/12] perf tools: Use same BPF program if arguments are identical Wang Nan <wangnan0@huawei.com> - 2015-11-13 13:40 +0100

csiph-web