Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268974

Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init

Show all headers | View raw

On 11/13/2015 12:31 AM, Maxime Ripard wrote:
> On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote:
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> The only difference is the readl vs readl_relaxed.
>>
>> Factor out the code with the clocksource_mmio_init function.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks for the review. I applied the patch with a fix:

ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1),
			node->name,
			rate, 340, UINT_MAX,
			clocksource_mmio_readl_down);

Replaced UINT_MAX by '32'.

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-12 19:50 +0100
  Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by  clocksource_mmio_init Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-13 00:40 +0100
    Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by  clocksource_mmio_init Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-13 15:30 +0100

csiph-web