Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols
Date	2015-11-13 15:00 +0100
Message-ID	<qun3s-77o-11@gated-at.bofh.it> (permalink)
References	<qtGrw-592-7@gated-at.bofh.it> <qu3xL-3gW-5@gated-at.bofh.it> <qu3xL-3gW-3@gated-at.bofh.it> <qujMe-5a8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 2015-11-13 11:24:33, Miroslav Benes wrote:
> On Thu, 12 Nov 2015, Chris J Arges wrote:
> 
> > From: Petr Mladek <pmladek@suse.com>
> > 
> > The livepatch module might be linked from several .o files.
> > All symbols that need to be shared between these .o files
> > should be exported. This is a normal programming practice.
> > I do not see any reason to access static symbols between
> > these .o files.
> > 
> > This patch removes the search for the static symbols within
> > the livepatch module. It makes it easier to understand
> > the meaning of the external flag and klp_find_external_symbol()
> > function.
> > 
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
> 
> I'd remove this patch from the patch set, because
> 
> 1. Josh needs to confirm that it is possible for kpatch to live without 
> external or that we can modify it. This could postpone this patch set as a 
> whole.
> 
> 2. I think the issue is quite independent of the problem this patch set 
> solves.
> 
> 3. I can even imagine that we could get rid of 'external' in klp_func and 
> its special handling completely if kpatch allows.
> 
> So let's solve it separately. Does anyone have a different opinion?

I agree. Let's solve this separately and leave it out for now.

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols Chris J Arges <chris.j.arges@canonical.com> - 2015-11-12 18:10 +0100
  Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external  symbols Miroslav Benes <mbenes@suse.cz> - 2015-11-13 11:30 +0100
    Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external  symbols Petr Mladek <pmladek@suse.com> - 2015-11-13 15:00 +0100

csiph-web