Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268748

Re: [PATCH] net: phy: vitesse: add support for VSC8601

Show all headers | View raw

Mason <slash.tmp@free.fr> writes:

> On 12/11/2015 19:41, Mans Rullgard wrote:
>
>> +	.phy_id         = PHY_ID_VSC8601,
>> +	.name           = "Vitesse VSC8601",
>> +	.phy_id_mask    = 0x000ffff0,
>> +	.features       = PHY_GBIT_FEATURES,
>> +	.flags          = PHY_HAS_INTERRUPT,
>> +	.config_init    = &genphy_config_init,
>> +	.config_aneg    = &genphy_config_aneg,
>> +	.read_status    = &genphy_read_status,
>> +	.ack_interrupt  = &vsc824x_ack_interrupt,
>> +	.config_intr    = &vsc82xx_config_intr,
>
> I expected Documentation/CodingStyle to forbid taking the address
> of functions.

I can't find anything to that effect.  That said, it's not something I
would normally do, but all the other phy_driver entries in that file
look like that.

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: vitesse: add support for VSC8601 Mans Rullgard <mans@mansr.com> - 2015-11-12 19:50 +0100
  Re: [PATCH] net: phy: vitesse: add support for VSC8601 Florian Fainelli <f.fainelli@gmail.com> - 2015-11-12 20:20 +0100
  Re: [PATCH] net: phy: vitesse: add support for VSC8601 Mason <slash.tmp@free.fr> - 2015-11-13 10:00 +0100
    Re: [PATCH] net: phy: vitesse: add support for VSC8601 Måns Rullgård <mans@mansr.com> - 2015-11-13 11:10 +0100

csiph-web