Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1268734

[PATCH] x86, mtrr: mark range_new in mtrr_calc_range_state() as __initdata

Path csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Rasmus Villemoes <linux@rasmusvillemoes.dk>
Newsgroups linux.kernel
Subject [PATCH] x86, mtrr: mark range_new in mtrr_calc_range_state() as __initdata
Date Fri, 13 Nov 2015 10:50:02 +0100
Message-ID <quj9w-4FD-3@gated-at.bofh.it> (permalink)
X-Original-To Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=krUZwr+4p4wJEbJBgWNXcadb0F0YSnllehl5kjkbVMY=; b=DAE8Z0ut6FVDXqlumiCIYNBRsnyU9TNcjaXlObbke50IVFEdYd/wn8I4NFZBmKXBHJ HwzNv3BkNlNRBrz2uKj2nykTQt/zgDyEoSOvE/AroSchOe7cE/kbIvZjiCHlbZ2rVPnR Ug0Cj9w0MExj8FRJERQKMgnO1AfNZ7YnKP26E=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=krUZwr+4p4wJEbJBgWNXcadb0F0YSnllehl5kjkbVMY=; b=QUkreLD6h3wIRS4KW2nTERH2KH1Z02ePbHVVN6vJbrnbK75pz75E+AXvGmTNCLafnN OpxsgxfHKbA9BZPdkTJ4Phlxvf71wFWF7GiVGfYg8Fc4w117KOZYRTpSxC90Tq639lwL NrulA5H1UvdCd0bftGJrm406UF3dH1pe50WkFhM4LRjrrpswrM/xuzOnO/te50qyJ7VG 079gfSJrfSUpp2RdDUutReEig9NJvYa0z4KCmnWHdCuMsOVh2jbFwzXrGcArgnlfrhVz iOB1U5pUz5vTtyOOyKyHWji6AUB/R3RPXQWpkEK05R91ZwtuamhiVl4FlWdvWYd+x7g7 /6dg==
X-Gm-Message-State ALoCoQlOC5GaRlH3shHyvbkP/o1QavHXTCr4D2mK7eUmHVzaJxkZ6XgyIW0hF56tOGe87Aj4Wu9E
X-Received by 10.25.151.133 with SMTP id z127mr9365854lfd.105.1447408081313; Fri, 13 Nov 2015 01:48:01 -0800 (PST)
X-Mailer git-send-email 2.6.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 37
Organization linux.* mail to news gateway
X-Original-Cc Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org
X-Original-Date Fri, 13 Nov 2015 10:47:53 +0100
X-Original-Message-ID <1447408073-25059-1-git-send-email-linux@rasmusvillemoes.dk>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1268734

Show key headers only | View raw


range_new doesn't seem to be used after init. It is only passed to
memset, sum_ranges, memcmp and x86_get_mtrr_mem_range, the latter of
which also only passes it on to various *range* library functions. So
mark it __initdata to free up an extra page after init.

nr_range_new is unconditionally assigned to before it is read, so
there's no point in having it static.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 arch/x86/kernel/cpu/mtrr/cleanup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mtrr/cleanup.c b/arch/x86/kernel/cpu/mtrr/cleanup.c
index 70d7c93f4550..b1a9ad366f67 100644
--- a/arch/x86/kernel/cpu/mtrr/cleanup.c
+++ b/arch/x86/kernel/cpu/mtrr/cleanup.c
@@ -593,9 +593,9 @@ mtrr_calc_range_state(u64 chunk_size, u64 gran_size,
 		      unsigned long x_remove_base,
 		      unsigned long x_remove_size, int i)
 {
-	static struct range range_new[RANGE_NUM];
+	static struct range range_new[RANGE_NUM] __initdata;
 	unsigned long range_sums_new;
-	static int nr_range_new;
+	int nr_range_new;
 	int num_reg;
 
 	/* Convert ranges to var ranges state: */
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] x86, mtrr: mark range_new in mtrr_calc_range_state() as __initdata Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-13 10:50 +0100

csiph-web