Re: [PATCH v3] PM / suspend: replacing printk

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] PM / suspend: replacing printk
Date	Sat, 14 Nov 2015 21:30:01 +0100
Message-ID	<quPCp-eG-1@gated-at.bofh.it> (permalink)
References	<qnH6W-3es-15@gated-at.bofh.it> <qopB0-5Ed-15@gated-at.bofh.it>
X-Original-To	Saurabh Sengar <saurabh.truth@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	rjw@rjwysocki.net, len.brown@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 14 Nov 2015 21:29:02 +0100
X-Original-Message-ID	<20151114202902.GD20429@amd>
X-Original-References	<saurabh.truth@gmail.com> <1446002641-3052-1-git-send-email-saurabh.truth@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1269534

Show key headers only | View raw

On Wed 2015-10-28 08:54:01, Saurabh Sengar wrote:
> replacing printk(s) with appropriate pr_info and pr_err
> in order to fix checkpatch.pl warnings
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

> @@ -245,7 +245,7 @@ static int suspend_test(int level)
>  {
>  #ifdef CONFIG_PM_DEBUG
>  	if (pm_test_level == level) {
> -		printk(KERN_INFO "suspend debug: Waiting for %d second(s).\n",
> +		pr_info("suspend debug: Waiting for %d second(s).\n",
>  				pm_test_delay);
>  		mdelay(pm_test_delay * 1000);
>  		return 1;
> @@ -317,7 +317,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
>  
>  	error = dpm_suspend_late(PMSG_SUSPEND);
>  	if (error) {
> -		printk(KERN_ERR "PM: late suspend of devices failed\n");
> +		pr_err("PM: late suspend of devices failed\n");
>  		goto Platform_finish;
>  	}
>  	error = platform_suspend_prepare_late(state);
> @@ -326,7 +326,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
>  
>  	error = dpm_suspend_noirq(PMSG_SUSPEND);
>  	if (error) {
> -		printk(KERN_ERR "PM: noirq suspend of devices failed\n");
> +		pr_err("PM: noirq suspend of devices failed\n");
>  		goto Platform_early_resume;
>  	}
>  	error = platform_suspend_prepare_noirq(state);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3] PM / suspend: replacing printk Pavel Machek <pavel@ucw.cz> - 2015-11-14 21:30 +0100

csiph-web