Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269504

Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label

Show all headers | View raw

On Thu, Nov 12, 2015 at 06:41:24PM -0500, Johannes Weiner wrote:
> Move the jump-label from sock_update_memcg() and sock_release_memcg()
> to the callsite, and so eliminate those function calls when socket
> accounting is not enabled.

I don't believe this patch's necessary, because these functions aren't
hot paths. Neither do I think it makes the code look better. Anyway,
it's rather a matter of personal preference, and the patch looks correct
to me, so

Reviewed-by: Vladimir Davydov <vdavydov@virtuozzo.com>

> 
> This also eliminates the need for dummy functions because the calls
> will be optimized away if the Kconfig options are not enabled.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label Johannes Weiner <hannes@cmpxchg.org> - 2015-11-13 00:50 +0100
  Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol  calls by jump-label David Miller <davem@davemloft.net> - 2015-11-13 17:10 +0100
  Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol  calls by jump-label Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-11-14 17:40 +0100
    Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol  calls by jump-label Johannes Weiner <hannes@cmpxchg.org> - 2015-11-16 19:00 +0100

csiph-web