Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269479

Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure

Show all headers | View raw

On Thu, Nov 12, 2015 at 06:41:22PM -0500, Johannes Weiner wrote:
> When charging socket memory, the code currently checks only the local
> page counter for excess to determine whether the memcg is under socket
> pressure. But even if the local counter is fine, one of the ancestors
> could have breached its limit, which should also force this child to
> enter socket pressure. This currently doesn't happen.
> 
> Fix this by using page_counter_try_charge() first. If that fails, it
> means that either the local counter or one of the ancestors are in
> excess of their limit, and the child should enter socket pressure.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: Vladimir Davydov <vdavydov@virtuozzo.com>

For the record: it was broken by commit 3e32cb2e0a12 ("mm: memcontrol:
lockless page counters").
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy Johannes Weiner <hannes@cmpxchg.org> - 2015-11-13 00:50 +0100
  [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure Johannes Weiner <hannes@cmpxchg.org> - 2015-11-13 00:50 +0100
    Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor  socket pressure David Miller <davem@davemloft.net> - 2015-11-13 17:10 +0100
    Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor  socket pressure Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-11-14 13:50 +0100
      Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor  socket pressure Johannes Weiner <hannes@cmpxchg.org> - 2015-11-14 16:20 +0100
  [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter Johannes Weiner <hannes@cmpxchg.org> - 2015-11-13 00:50 +0100
  [PATCH 01/14] mm: memcontrol: export root_mem_cgroup Johannes Weiner <hannes@cmpxchg.org> - 2015-11-13 00:50 +0100
    Re: [PATCH 01/14] mm: memcontrol: export root_mem_cgroup David Miller <davem@davemloft.net> - 2015-11-13 17:00 +0100
    Re: [PATCH 01/14] mm: memcontrol: export root_mem_cgroup Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-11-14 13:20 +0100
  [PATCH 10/14] mm: memcontrol: generalize the socket accounting jump label Johannes Weiner <hannes@cmpxchg.org> - 2015-11-13 00:50 +0100
    Re: [PATCH 10/14] mm: memcontrol: generalize the socket accounting  jump label Michal Hocko <mhocko@kernel.org> - 2015-11-13 11:50 +0100
    Re: [PATCH 10/14] mm: memcontrol: generalize the socket accounting  jump label Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-11-14 14:40 +0100

csiph-web