Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1269429

Re: [PATCH] staging: most: aim-cdev: Used "==" instead of assignment

Show all headers | View raw

On Sat, Nov 14, 2015 at 09:57:10AM +0530, Anjali Menon wrote:
> Used double equal sign instead of equal to sign in the if condition
> to remove the error detected by checkpatch.pl.
> 
> ERROR: do not use assignment in if condition
> 
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
>  drivers/staging/staging/drivers/staging/most/aim-cdev/cdev.c | 2 +-

something wrong with your tree. This path doesnot exist.

But in any case, i think the patch is wrong. wait_event_interruptible()
is executed when most_get_mbo() returns NULL. so if you do
mbo == most_get_mbo() it will immediately come out of sleep as the
condition is true. I think here the intention was to sleep as long as
most_get_mbo() returns NULL. And when it returns a valid pointer it is
saved in mbo variable so that it can be used later in copy_from_user().

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: most: aim-cdev: Used "==" instead of assignment Anjali Menon <cse.anjalimenon@gmail.com> - 2015-11-14 05:30 +0100
  Re: [PATCH] staging: most: aim-cdev: Used "==" instead of assignment Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-14 08:10 +0100

csiph-web