Re: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement
Date	Sat, 14 Nov 2015 07:50:02 +0100
Message-ID	<quCOS-zo-5@gated-at.bofh.it> (permalink)
References	<quoCd-8cf-5@gated-at.bofh.it> <quoCd-8cf-7@gated-at.bofh.it>
X-Original-To	Nizam Haider <nizamhaider786@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=rmlJ7dUdgS/R33ZxLx53R2ni7180ZbYFHhh8lk7UgSs=; b=ZoBIRZvLBbe/kpp4ebkooodPNNf3JQ5ZvXQHk6Vp537+F7J/9wUVwkdXuJW40BhMDg 2VzDzL5pBE5HNXyILrt/V6+FavD5e/ojm6Zs/m85Vn5gDBLMCMeyOASYqkJLRj9y9XBl q09QyNRfDIIpk62Np81rg8vJbrp3pWon9e+narXU9bdDfHeDSxmQvrru9L8/Vnjl0lOP jPn+aDkGcZIWaTs+0nxD8I0vPW4zg4NcYhBr5zXSfJr/h3MXAdecLT1IpcrmOnIZS6AA srKCZ71IeRr7KAk2YOhYUOpSspYieoyTTyRv+Odsxuo0nCHnI1qbHPCC3nwv57SRUud5 +Quw==
X-Received	by 10.68.173.165 with SMTP id bl5mr37283172pbc.75.1447483431536; Fri, 13 Nov 2015 22:43:51 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nizam Haider <nijamh@cdac.in>
X-Original-Date	Sat, 14 Nov 2015 12:13:44 +0530
X-Original-Message-ID	<20151114064344.GB3685@sudip-pc>
X-Original-References	<1447428837-24098-1-git-send-email-nizamhaider786@gmail.com> <1447428837-24098-4-git-send-email-nizamhaider786@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1269426

Show key headers only | View raw

On Fri, Nov 13, 2015 at 09:03:56PM +0530, Nizam Haider wrote:
> Fix Checlpatch warning
> HECK: braces {} should be used on all arms of this statement
> 
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e980150..99b230f 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1108,9 +1108,10 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch)
>  	 * On the other hand, if the UART IS in FIFO mode, then ask
>  	 * the UART to give us an approximation of data it has RX'ed.
>  	 */
> -	if (!(ch->ch_flags & CH_FIFO_ENABLED))
> +	if (!(ch->ch_flags & CH_FIFO_ENABLED)) {
>  		total = 0;
> -	else {
> +	}
> +		else {

This should be:

diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index e980150..67e2667 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1108,9 +1108,9 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch)
 	 * On the other hand, if the UART IS in FIFO mode, then ask
 	 * the UART to give us an approximation of data it has RX'ed.
 	 */
-	if (!(ch->ch_flags & CH_FIFO_ENABLED))
+	if (!(ch->ch_flags & CH_FIFO_ENABLED)) {
 		total = 0;
-	else {
+	} else {
 		total = readb(&ch->ch_neo_uart->rfifo);
 
 		/*

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement Nizam Haider <nizamhaider786@gmail.com> - 2015-11-13 16:40 +0100
  Re: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be  used on all arms of this statement Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-14 07:50 +0100

csiph-web