Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268316

[PATCH 4/6] perf hists browser: Fix 'd' hotkey action to filter by DSO

Show all headers | View raw

From: Arnaldo Carvalho de Melo <acme@redhat.com>

When pressing 'd' the expected action is to filter all entries by the
DSO in the current entry, but for that the action->map needs to be set,
and only action->dso was being set, fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: 045b80dd0340 ("perf hists browser: Use the map to determine if a DSO is being used as a kernel")
Link: http://lkml.kernel.org/n/tip-xqhfzgoblq49lk5h5u82atro@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/browsers/hists.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index e5afb8936040..a7ce0cf117e7 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1875,6 +1875,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
 			continue;
 		case 'd':
 			actions->dso = dso;
+			actions->ms.map = map;
 			do_zoom_dso(browser, actions);
 			continue;
 		case 'V':
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 00:00 +0100
  [PATCH 1/6] tools: Actually install tmon in the install rule Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 00:00 +0100
  [PATCH 4/6] perf hists browser: Fix 'd' hotkey action to filter by DSO Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 00:00 +0100
  [PATCH 3/6] perf symbols: Rebuild rbtree when adjusting symbols for kcore Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 00:00 +0100
  [PATCH 2/6] tools: Add a "make all" rule Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-13 00:00 +0100
  Re: [GIT PULL 0/6] perf/urgent fixes Ingo Molnar <mingo@kernel.org> - 2015-11-13 10:20 +0100

csiph-web