Re: [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area()

From	David Rientjes <rientjes@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area()
Date	2015-11-12 22:00 +0100
Message-ID	<qu78m-5oc-13@gated-at.bofh.it> (permalink)
References	<qu1Pj-27m-9@gated-at.bofh.it> <qu34K-2QO-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 12 Nov 2015, Jerome Marchand wrote:

> Commit 71394fe50146 ("mm: vmalloc: add flag preventing guard hole
> allocation") missed a spot. Currently remove_vm_area() decreases
> vm->size to "remove" the guard hole page, even when it isn't present.
> All but one users just free the vm_struct rigth away and never access
> vm->size anyway.
> Don't touch the size in remove_vm_area() and have __vunmap() use the
> proper get_vm_area_size() helper.
> 
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>

Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area() "Jerome Marchand" <jmarchan@redhat.com> - 2015-11-12 16:20 +0100
  Re: [PATCH] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area() Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-11-12 17:00 +0100
    Re: [PATCH] mm: vmalloc: don't remove inexistent guard hole in  remove_vm_area() Jerome Marchand <jmarchan@redhat.com> - 2015-11-12 17:30 +0100
  [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area() "Jerome Marchand" <jmarchan@redhat.com> - 2015-11-12 17:40 +0100
    Re: [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area() Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-11-12 19:50 +0100
    Re: [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in  remove_vm_area() David Rientjes <rientjes@google.com> - 2015-11-12 22:00 +0100

csiph-web