Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1268212
| From | Mason <slash.tmp@free.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 |
| Date | 2015-11-12 20:10 +0100 |
| Message-ID | <qu5pT-4sN-3@gated-at.bofh.it> (permalink) |
| References | <qu4at-3v0-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/11/2015 18:40, Mans Rullgard wrote:
> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode"
> added interrupt support for the 8031 PHY but left out the other two
> chips supported by this driver.
>
> This patch sets the .ack_interrupt and .config_intr functions for the
> 8030 and 8035 drivers as well.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> I have only tested this with an 8035. I can't find a datasheet for
> the 8030, but since 8031, 8032, and 8035 all have the same register
> layout, there's a good chance 8030 does as well.
> ---
> drivers/net/phy/at803x.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index fabf11d..2d020a3 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -308,6 +308,8 @@ static struct phy_driver at803x_driver[] = {
> .flags = PHY_HAS_INTERRUPT,
> .config_aneg = genphy_config_aneg,
> .read_status = genphy_read_status,
> + .ack_interrupt = at803x_ack_interrupt,
> + .config_intr = at803x_config_intr,
> .driver = {
> .owner = THIS_MODULE,
> },
> @@ -327,6 +329,8 @@ static struct phy_driver at803x_driver[] = {
> .flags = PHY_HAS_INTERRUPT,
> .config_aneg = genphy_config_aneg,
> .read_status = genphy_read_status,
> + .ack_interrupt = at803x_ack_interrupt,
> + .config_intr = at803x_config_intr,
> .driver = {
> .owner = THIS_MODULE,
> },
Shouldn't we take the opportunity to clean up the duplicated register
definitions? (I'll send an informal patch to spur discussion.)
Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Mans Rullgard <mans@mansr.com> - 2015-11-12 18:50 +0100
Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Måns Rullgård <mans@mansr.com> - 2015-11-12 20:10 +0100
Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Florian Fainelli <f.fainelli@gmail.com> - 2015-11-12 20:20 +0100
Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Mason <slash.tmp@free.fr> - 2015-11-12 23:20 +0100
Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Måns Rullgård <mans@mansr.com> - 2015-11-12 23:30 +0100
Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Mason <slash.tmp@free.fr> - 2015-11-12 20:10 +0100
Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035 Florian Fainelli <f.fainelli@gmail.com> - 2015-11-12 20:20 +0100
csiph-web