Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268191

[PATCH] lightnvm: change max_phys_sect to ushort

Show all headers | View raw

The max_phys_sect variable is defined as a char. We do a boundary check
to maximally allow 256 physical page descriptors per command. As we are
not indexing from zero. This expression is always in false. Bump the
max_phys_sect to an unsigned short to support the range check.

Signed-off-by: Matias Bjørling <m@bjorling.me>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 include/linux/lightnvm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index 69c9057..4b1cd3d 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -220,7 +220,7 @@ struct nvm_dev_ops {
 	nvm_dev_dma_alloc_fn	*dev_dma_alloc;
 	nvm_dev_dma_free_fn	*dev_dma_free;
 
-	uint8_t			max_phys_sect;
+	unsigned int max_phys_sect;
 };
 
 struct nvm_lun {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] lightnvm: change max_phys_sect to ushort Matias Bjørling <m@bjorling.me> - 2015-11-12 19:40 +0100
  Re: [PATCH] lightnvm: change max_phys_sect to ushort Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-12 19:50 +0100
    Re: [PATCH] lightnvm: change max_phys_sect to ushort Matias Bjørling <m@bjorling.me> - 2015-11-12 20:00 +0100
      Re: [PATCH] lightnvm: change max_phys_sect to ushort Matias Bjørling <m@bjorling.me> - 2015-11-12 20:10 +0100
      Re: [PATCH] lightnvm: change max_phys_sect to ushort Linus Torvalds <torvalds@linux-foundation.org> - 2015-11-12 20:10 +0100

csiph-web