Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1268180
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] PM / wakeirq: check that wake IRQ is valid before accepting it |
| Date | 2015-11-12 19:30 +0100 |
| Message-ID | <qu4Nc-3Zg-37@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Check that IRQ number passed to dev_pm_set_wake_irq and dev_pm_set_dedicated_wake_irq is valid (not negative) before accepting it. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- My recent change to i2c core introduced a code path that led to calling dev_pm_set_wake_irq(&client->dev, -ENOENT), which succeeded but obviously did the wrong thing. Checking the IRQ and bailing out early would have helped noticing this issue earlier. drivers/base/power/wakeirq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c index eb6e674..0d77cd6 100644 --- a/drivers/base/power/wakeirq.c +++ b/drivers/base/power/wakeirq.c @@ -68,6 +68,9 @@ int dev_pm_set_wake_irq(struct device *dev, int irq) struct wake_irq *wirq; int err; + if (irq < 0) + return -EINVAL; + wirq = kzalloc(sizeof(*wirq), GFP_KERNEL); if (!wirq) return -ENOMEM; @@ -167,6 +170,9 @@ int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq) struct wake_irq *wirq; int err; + if (irq < 0) + return -EINVAL; + wirq = kzalloc(sizeof(*wirq), GFP_KERNEL); if (!wirq) return -ENOMEM; -- 2.6.0.rc2.230.g3dd15c0 -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] PM / wakeirq: check that wake IRQ is valid before accepting it Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-12 19:30 +0100
Re: [PATCH] PM / wakeirq: check that wake IRQ is valid before accepting it Grygorii Strashko <grygorii.strashko@ti.com> - 2015-11-12 19:50 +0100
Re: [PATCH] PM / wakeirq: check that wake IRQ is valid before accepting it Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-12 20:00 +0100
Re: [PATCH] PM / wakeirq: check that wake IRQ is valid before accepting it "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-14 00:50 +0100
csiph-web