Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1267942

Re: [Y2038] [PATCH] fs:affs:Replace time_t with time64_t

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [Y2038] [PATCH] fs:affs:Replace time_t with time64_t
Date 2015-11-12 14:50 +0100
Message-ID <qu0qf-16P-37@gated-at.bofh.it> (permalink)
References <qu0qf-16P-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thursday 12 November 2015 21:40:41 DengChao wrote:
> The affs code uses "time_t" and "get_seconds()". This will cause
> problems on 32-bit architectures in 2038 when time_t overflows.
> This patch replaces them with "time64_t" and
> "ktime_get_real_seconds()". This patch introduces expensive 64-bit
> divsion in "secs_to_datestamp()", considering this function is not
> called so often, the cost should be acceptable.  
> 
> Signed-off-by: DengChao <chao.deng@linaro.org>
> 

Looks good,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Is anyone picking up patches for random unmaintained file systems,
or should we put it into the y2038 tree?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] fs:affs:Replace time_t with time64_t DengChao <chao.deng@linaro.org> - 2015-11-12 14:50 +0100
  Re: [Y2038] [PATCH] fs:affs:Replace time_t with time64_t Arnd Bergmann <arnd@arndb.de> - 2015-11-12 14:50 +0100

csiph-web