Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266809

Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check fixup tables

Show all headers | View raw

On Tue, Nov 10, 2015 at 12:21:16PM +0100, Borislav Petkov wrote:
> > +# define _ASM_MCEXTABLE(from, to)				\
> 
> Maybe add an intermediary macro which abstracts the table name:
> 
> #define __ASM_EXTABLE(from, to, table)
> ...
> 
> and then do
> 
> #define _ASM_EXTABLE(from, to)		__ASM_EXTABLE(from, to, "__ex_table")
> #define _ASM_MCEXTABLE(from, to)	__ASM_EXTABLE(from, to, "__mcex_table")

That looks a bit nicer.
> 
> Yeah, all that duplication might raise some brows but I'd guess
> special-handling MCA in the normal exception paths might make the code
> a bit too ugly...

The 0-day robot berated me for bloating the i386-tinyconfig by 88 bytes.
I guess I can put the new functions inside #ifdef CONFIG_MEMORY_FAILURE
to save them from that. Enterprise kernels that turn this option on can
probably live with 88 bytes.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] x86, ras: Add new infrastructure for machine check fixup  tables Tony Luck <tony.luck@intel.com> - 2015-11-09 19:50 +0100
  Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check  fixup tables Borislav Petkov <bp@alien8.de> - 2015-11-10 12:30 +0100
    Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check  fixup tables "Luck, Tony" <tony.luck@intel.com> - 2015-11-10 23:10 +0100
  Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check  fixup tables Andy Lutomirski <luto@kernel.org> - 2015-11-12 05:20 +0100
    Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check  fixup tables "Luck, Tony" <tony.luck@intel.com> - 2015-11-12 20:50 +0100
      Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check  fixup tables Andy Lutomirski <luto@amacapital.net> - 2015-11-12 21:10 +0100
        Re: [PATCH 1/3] x86, ras: Add new infrastructure for machine check  fixup tables "Luck, Tony" <tony.luck@intel.com> - 2015-11-12 22:20 +0100

csiph-web