Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS
Date	2015-11-10 21:50 +0100
Message-ID	<qto1A-1vO-15@gated-at.bofh.it> (permalink)
References	<qtnId-1o6-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 10 November 2015 15:28:17 Steven Rostedt wrote:
> Arnd Bergmann reported:
> 
>   In my ARM randconfig tests, I'm getting a build error for
>   newly added code in bpf_perf_event_read and bpf_perf_event_output
>   whenever CONFIG_PERF_EVENTS is disabled:
> 
>   kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
>   kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
>   if (event->oncpu != smp_processor_id() ||
>            ^
>   kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
>         event->pmu->count)
> 
>   This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
>   is disabled. I'm not sure if that is a configuration we care
>   about, otherwise we could prevent this case from occuring by
>   adding Kconfig dependencies.
> 
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
> 
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv@wuerfel
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> 

Ok, sounds good.

Acked-by: Arnd Bergmann <arnd@arndb.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bpf_trace: Make dependent on PERF_EVENTS Steven Rostedt <rostedt@goodmis.org> - 2015-11-10 21:30 +0100
  Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS David Miller <davem@davemloft.net> - 2015-11-10 21:50 +0100
    Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS Steven Rostedt <rostedt@goodmis.org> - 2015-11-10 21:50 +0100
  Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS Arnd Bergmann <arnd@arndb.de> - 2015-11-10 21:50 +0100

csiph-web