Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266727

RE: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

Show all headers | View raw

> -----Original Message-----
> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of
> Hoemann, Jerry
> Sent: Friday, November 6, 2015 4:27 PM
> Subject: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.
...
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
...
> +struct ndn_pkg {
> +	struct {
> +		__u8	dsm_uuid[16];
> +		__u32	dsm_in;			/* size of _DSM input    */
> +		__u32	dsm_out;		/* size of user buffer   */
> +		__u32	dsm_rev;		/* revision of dsm call  */
> +		__u32	res[8];			/* reserved must be zero */
> +		__u32	dsm_size;		/* size _DSM would write */
> +	} h;
> +	unsigned char buf[];
> +} __packed;

Given that the _DSM arguments are defined as:
* Arg0 UUID: Buffer of 16 bytes
* Arg1 Revision ID: Integer (8 bytes)
* Arg2 Function Index: Integer (8 bytes)
* Arg3 Package: function-specific

1. The __u32 for dsm_rev is not big enough to express all
possible 8 byte Revision IDs.

2. The unsigned int cmd (carried outside this structure)
is not big enough on all platforms (e.g., 32-bit) to 
express all possible Function Indexes.

3. The Revision ID and Function Index values passed to 
the _DSM are defined as little-endian.  Are they
intended to use native endianness or be little-endian
in this structure?

---
Robert Elliott, HPE Persistent Memory



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-06 23:30 +0100
  [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-06 23:30 +0100
    Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jeff Moyer <jmoyer@redhat.com> - 2015-11-10 19:00 +0100
      Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Dan Williams <dan.j.williams@intel.com> - 2015-11-10 19:10 +0100
      Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-10 20:50 +0100
        Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jeff Moyer <jmoyer@redhat.com> - 2015-11-10 21:30 +0100
          Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-11 01:50 +0100
            Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Dan Williams <dan.j.williams@intel.com> - 2015-11-11 01:50 +0100
            Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jeff Moyer <jmoyer@redhat.com> - 2015-11-11 16:50 +0100
        Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Dan Williams <dan.j.williams@intel.com> - 2015-11-10 21:30 +0100
          Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Linda Knippers <linda.knippers@hpe.com> - 2015-11-10 22:00 +0100
            Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Dan Williams <dan.j.williams@intel.com> - 2015-11-10 23:30 +0100
    RE: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2015-11-10 20:10 +0100
      Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-10 22:40 +0100
  Re: [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls Jeff Moyer <jmoyer@redhat.com> - 2015-11-10 16:40 +0100
    Re: [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-10 22:40 +0100

csiph-web