Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266742

Re: [PATCH V4] PM / OPP: Add debugfs support

Show all headers | View raw

Minor nitpicks. Looks mostly fine.

On 11/05, Viresh Kumar wrote:
> diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c
> new file mode 100644
> index 000000000000..b512a76ef0df
> --- /dev/null
> +++ b/drivers/base/power/opp/debugfs.c
> @@ -0,0 +1,216 @@
> +/*
> + * Generic OPP debugfs interface
> + *
> + * Copyright (C) 2015-2016 Viresh Kumar <viresh.kumar@linaro.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/debugfs.h>
> +#include <linux/err.h>

#include <linux/init.h>
#include <linux/limits.h>
#include <linux/device.h>

> +
> +#include "opp.h"
> +
[..]
> @@ -69,6 +71,7 @@ struct dev_pm_opp {
>  	bool available;
>  	bool dynamic;
>  	bool turbo;
> +	bool suspend;

This should be documented as well.

>  	unsigned long rate;
>  
>  	unsigned long u_volt;
> @@ -81,6 +84,11 @@ struct dev_pm_opp {
>  	struct rcu_head rcu_head;
>  
>  	struct device_node *np;
> +
> +#ifdef CONFIG_DEBUG_FS
> +	/* debugfs */

This comment is pretty useless (for all three instances).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4] PM / OPP: Add debugfs support Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-05 10:40 +0100
  Re: [PATCH V4] PM / OPP: Add debugfs support "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-07 01:40 +0100
  Re: [PATCH V4] PM / OPP: Add debugfs support Stephen Boyd <sboyd@codeaurora.org> - 2015-11-10 20:40 +0100
    [PATCH V5] PM / OPP: Add debugfs support Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-11 03:30 +0100
      Re: [PATCH V5] PM / OPP: Add debugfs support Stephen Boyd <sboyd@codeaurora.org> - 2015-11-11 23:00 +0100

csiph-web