Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266466

Re: [RFC PATCH 3/3] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros

Show all headers | View raw

* Borislav Petkov <bp@alien8.de> wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> Those are stupid and code should use static_cpu_has_safe() anyway. Kill
> the least used and unused ones.

So cpufeature.h doesn't really do a good job of explaining what the difference is 
between all these variants:

	cpu_has()
	static_cpu_has()
	static_cpu_has_safe()

it has this comment:

/*
 * Static testing of CPU features.  Used the same as boot_cpu_has().
 * These are only valid after alternatives have run, but will statically
 * patch the target code for additional performance.
 */

The second sentence does not parse. Why does the third sentence have a 'but' for 
listing properties? It's either bad grammer or tries to tell something that isn't 
being told properly.

It's entirely silent on the difference between static_cpu_has() and 
static_cpu_has_safe() - what makes the second one 'safe'?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] x86/cpufeature: Cleanup stuff Borislav Petkov <bp@alien8.de> - 2015-11-10 12:50 +0100
  [RFC PATCH 2/3] x86/cpufeature: Cleanup get_cpu_cap() Borislav Petkov <bp@alien8.de> - 2015-11-10 12:50 +0100
  [RFC PATCH 3/3] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros Borislav Petkov <bp@alien8.de> - 2015-11-10 12:50 +0100
    Re: [RFC PATCH 3/3] x86/cpufeature: Remove unused and seldomly used  cpu_has_xx macros David Sterba <dsterba@suse.cz> - 2015-11-10 13:00 +0100
    Re: [RFC PATCH 3/3] x86/cpufeature: Remove unused and seldomly used  cpu_has_xx macros Ingo Molnar <mingo@kernel.org> - 2015-11-10 13:40 +0100
      Re: [RFC PATCH 3/3] x86/cpufeature: Remove unused and seldomly used  cpu_has_xx macros Borislav Petkov <bp@alien8.de> - 2015-11-10 13:50 +0100
  [RFC PATCH 1/3] x86/cpufeature: Move some of the scattered feature bits to x86_capability Borislav Petkov <bp@alien8.de> - 2015-11-10 13:00 +0100

csiph-web