Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config
Date	2015-11-10 11:10 +0100
Message-ID	<qte2e-3Ga-13@gated-at.bofh.it> (permalink)
References	<qrRAK-6pR-9@gated-at.bofh.it> <qrRKr-6IF-15@gated-at.bofh.it> <qrRU6-6M2-7@gated-at.bofh.it> <qrS3M-6Pn-15@gated-at.bofh.it> <qtbQK-27M-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Heiko,

On Tue, Nov 10, 2015 at 08:41:24AM +0100, Heiko Carstens wrote:
> On Fri, Nov 06, 2015 at 04:21:10PM +0000, Will Deacon wrote:
> > On Sat, Nov 07, 2015 at 12:11:16AM +0800, yalin wang wrote:
> > > i just enable it on ARM64,
> > > and it can work,
> > > i don’t see some special requirement to enable this config .
> > 
> > Right, so why does HAVE_LATENCYTOP_SUPPORT exist?
> 
> If I remember correctly then the only dependency was that an architecture
> must have implemented save_stack_trace_tsk().
> See git commit a3afe70b83fdbbd4d757d2911900d168bc798a31.

Thanks for the pointer.

> So the name of HAVE_LATENCYTOP_SUPPORT is surely a not well chosen, and I
> think I introduced it back then. Oh, well.
> 
> And looking through the kernel there is at least avr32 which would break
> at build time if the config option would be removed completely.
> 
> So.. renaming it to STACKTRACE_TSK_SUPPORT would be a good idea.

ftrace has a similar issue and solves it by having architectures define
a `config STACKTRACE_SUPPORT' symbol. Over in kernel/trace/Kconfig,
there's a `select STACKTRACE if STACKTRACE_SUPPORT', which means
that kernel/stacktrace.c gets built and a dummy (weak symbol) version of
save_stack_trace_tsk appears.

I don't think adding another STACKTRACE-related Kconfig option is
necessarily the best thing to do. Maybe we should instead have LATENCYTOP
depend on STACKTRACE_SUPPORT (already the case) and select STACKTRACE?

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config yalin wang <yalin.wang2010@gmail.com> - 2015-11-06 17:00 +0100
  Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Will Deacon <will.deacon@arm.com> - 2015-11-06 17:10 +0100
    Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config yalin wang <yalin.wang2010@gmail.com> - 2015-11-06 17:20 +0100
      Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Will Deacon <will.deacon@arm.com> - 2015-11-06 17:30 +0100
        Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-11-10 08:50 +0100
          Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Will Deacon <will.deacon@arm.com> - 2015-11-10 11:10 +0100
            Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-11-10 12:10 +0100
              Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Will Deacon <will.deacon@arm.com> - 2015-11-10 12:20 +0100
                Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config yalin wang <yalin.wang2010@gmail.com> - 2015-11-10 12:30 +0100
                Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-11-10 12:40 +0100

csiph-web