Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267882

Re: [PATCH] PCI: hisi: Fix Section mismatch compilation warning for probe()

Show all headers | View raw

On Thursday 12 November 2015 20:02:08 Jisheng Zhang wrote:
> Following compilation warning occurs when compiled with:
> CONFIG_DEBUG_SECTION_MISMATCH=y
> 
>  WARNING: drivers/pci/host/built-in.o(.data+0x308): Section mismatch in
>  reference from the variable hisi_pcie_driver to the function
>  .init.text:hisi_pcie_probe()
> 
> Fix it by dropping __init from hisi_pcie_probe().

The patch description should ideally say what the impact is here, not
only what the warning says.

> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> Fixes: 500a1d9a43e0 ("PCI: hisi: Add HiSilicon SoC Hip05 PCIe driver")
> ---
>  drivers/pci/host/pcie-hisi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-hisi.c b/drivers/pci/host/pcie-hisi.c
> index 35457ec..1cc0a21 100644
> --- a/drivers/pci/host/pcie-hisi.c
> +++ b/drivers/pci/host/pcie-hisi.c
> @@ -139,7 +139,7 @@ static int __init hisi_add_pcie_port(struct pcie_port *pp,
>         return 0;
>  }
>  
> -static int __init hisi_pcie_probe(struct platform_device *pdev)
> +static int hisi_pcie_probe(struct platform_device *pdev)
>  {
>         struct hisi_pcie *hisi_pcie;
>         struct pcie_port *pp;

This seems incomplete, you now get a new warning about hisi_add_pcie_port().

I did a similar patch yesterday, will follow up with my version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: hisi: Fix Section mismatch compilation warning for probe() Jisheng Zhang <jszhang@marvell.com> - 2015-11-12 13:10 +0100
  [PATCH] PCI: hisi: fix deferred probing Arnd Bergmann <arnd@arndb.de> - 2015-11-12 13:30 +0100
    RE: [PATCH] PCI: hisi: fix deferred probing Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-11-13 04:10 +0100
    Re: [PATCH] PCI: hisi: fix deferred probing Zhou Wang <wangzhou1@hisilicon.com> - 2015-11-13 08:30 +0100
  Re: [PATCH] PCI: hisi: Fix Section mismatch compilation warning for  probe() Jisheng Zhang <jszhang@marvell.com> - 2015-11-12 13:30 +0100
  Re: [PATCH] PCI: hisi: Fix Section mismatch compilation warning for probe() Arnd Bergmann <arnd@arndb.de> - 2015-11-12 13:30 +0100

csiph-web