Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267757

Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

Show all headers | View raw

On Thu, Nov 12, 2015 at 11:07 AM, dave penkler <dpenkler@gmail.com> wrote:
> Thanks for your comments, I will resubmit taking into account all
> suggestions.
>
>> >  - redundant parens

Example 1.
+                       (atomic_read(&data->iin_data_valid) != 0),

>> >  - pieces of code takes whole line when they are quite fit tail of
>> > previous one.
>> >
>
>
> I have endeavoured to follow the coding style of the original driver and
> stick to the kernel coding-style guidelines.
> Please point to the specific locations where I have failed to do so.

Example 1.
+               dev_err(dev, "control status returned %x\n",
+                       buffer[0]);

example 2.
+                       USBTMC_TIMEOUT
+                       );


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5]  usb: usbtmc: Add support for missing functions in  USBTMC-USB488 spec Dave Penkler <dpenkler@gmail.com> - 2015-11-11 12:10 +0100
  [PATCH v3 3/5] Add support for receiving USBTMC USB488 SRQ  notifications via poll/select Dave Penkler <dpenkler@gmail.com> - 2015-11-11 12:20 +0100
    Re: [PATCH v3 3/5] Add support for receiving USBTMC USB488 SRQ  notifications via poll/select Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-11 20:10 +0100
  [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488  READ_STATUS_BYTE operation. Dave Penkler <dpenkler@gmail.com> - 2015-11-11 12:20 +0100
    Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488  READ_STATUS_BYTE operation. Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-11 20:10 +0100
      Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488  READ_STATUS_BYTE operation. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-11 20:50 +0100
        Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488  READ_STATUS_BYTE operation. Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-11 21:00 +0100
      Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488  READ_STATUS_BYTE operation. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-11 22:10 +0100
        Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488  READ_STATUS_BYTE operation. Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-12 10:50 +0100
  [PATCH v3 2/5] Add support for USBTMC USB488 SRQ notification with  fasync Dave Penkler <dpenkler@gmail.com> - 2015-11-11 12:20 +0100
  [PATCH v3 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities Dave Penkler <dpenkler@gmail.com> - 2015-11-11 12:30 +0100
    Re: [PATCH v3 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-11 20:40 +0100
  [PATCH v3 5/5] Add ioctls to enable and disable local controls on an  instrument Dave Penkler <dpenkler@gmail.com> - 2015-11-11 12:30 +0100
    Re: [PATCH v3 5/5] Add ioctls to enable and disable local controls on  an instrument Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-11 20:40 +0100
      Re: [PATCH v3 5/5] Add ioctls to enable and disable local controls  on an instrument Dave Penkler <dpenkler@gmail.com> - 2015-11-13 10:10 +0100

csiph-web