Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267715

Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference

Show all headers | View raw

On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote:
>> Hi,
>>
>> On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin
>> <clabbe.montjoie@gmail.com> wrote:
>> > of_match_device could return NULL, and so cause a NULL pointer
>> > dereference later.
>>
>> Did you actually run into this? It seems to me that this driver is
>> only probed if and only if we have a match and that therefore
>> of_match_device will always return a valid pointer (it is using the
>> same match table). Am I missing something?
>
> Yes, you're missing something. The driver would probe for a dt snippet
> like:
>
>         mxc_nand {
>                 compatible = "foobar";
>         }
>
> In this case dev->of_node is non-NULL but of_match_device(mxcnd_dt_ids,
> dev) is.
>
> (I didn't actually test this, so there is a chance I'm wrong here. And
> if not I wonder if it is sensible at all to match the device name on
> driver name for of-created platform devices.)

Yea, looks like you're right. platform devices check a number of
things to determine a match, among which is driver name if all else
fails (platform.c, platform_match()).

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 08:50 +0100
  Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Frans Klaver <fransklaver@gmail.com> - 2015-11-12 09:10 +0100
    Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 09:30 +0100
      Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Frans Klaver <fransklaver@gmail.com> - 2015-11-12 09:40 +0100
        Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Frans Klaver <fransklaver@gmail.com> - 2015-11-12 10:00 +0100
          Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 10:10 +0100
        Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 10:00 +0100
  Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 09:20 +0100
    Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference LABBE Corentin <montjoie.mailing@gmail.com> - 2015-11-12 11:10 +0100
      Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 11:20 +0100

csiph-web