Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267669
| From | Alexandre Courbot <acourbot@nvidia.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] drm/tegra: fix locking of SET_TILING ioctl |
| Date | 2015-11-12 08:20 +0100 |
| Message-ID | <qtUkO-5Od-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
drm_gem_object_unreference() now expects obj->dev->struct_mutex to be held. Use the newly-introduced drm_gem_object_unreference_unlocked() which handles locking for us. If we don't do this drm_gem_object_unreference() will get noisy about struct_mutex not being held every time we call the SET_TILING ioctl. Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> --- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index cc48334ef164..c0ae89865958 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -683,7 +683,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, void *data, bo->tiling.mode = mode; bo->tiling.value = value; - drm_gem_object_unreference(gem); + drm_gem_object_unreference_unlocked(gem); return 0; } -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] drm/tegra: fix locking of SET_TILING ioctl Alexandre Courbot <acourbot@nvidia.com> - 2015-11-12 08:20 +0100
csiph-web