Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267625

Re: [PATCH v4 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver

Show all headers | View raw

On 10.11.2015 20:43, Pankaj Dubey wrote:
> This patch moves exynos_sys_powerdown_conf function above all
> static functions.

Please (always) describe the reason, the answer to "why?". In this case
I know why, but other reviewers may not and other people grepping
through history definitely won't know.

Best regards,
Krzysztof

> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  arch/arm/mach-exynos/pmu.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
> index e01bdf1..f300ac9 100644
> --- a/arch/arm/mach-exynos/pmu.c
> +++ b/arch/arm/mach-exynos/pmu.c
> @@ -39,23 +39,6 @@ u32 pmu_raw_readl(u32 offset)
>  	return readl_relaxed(pmu_base_addr + offset);
>  }
>  
> -static void exynos_power_off(void)
> -{
> -	unsigned int tmp;
> -
> -	pr_info("Power down.\n");
> -	tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL);
> -	tmp ^= (1 << 8);
> -	pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL);
> -
> -	/* Wait a little so we don't give a false warning below */
> -	mdelay(100);
> -
> -	pr_err("Power down failed, please power off system manually.\n");
> -	while (1)
> -		;
> -}
> -
>  void exynos_sys_powerdown_conf(enum sys_powerdown mode)
>  {
>  	unsigned int i;
> @@ -85,6 +68,23 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode)
>  	}
>  }
>  
> +static void exynos_power_off(void)
> +{
> +	unsigned int tmp;
> +
> +	pr_info("Power down.\n");
> +	tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL);
> +	tmp ^= (1 << 8);
> +	pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL);
> +
> +	/* Wait a little so we don't give a false warning below */
> +	mdelay(100);
> +
> +	pr_err("Power down failed, please power off system manually.\n");
> +	while (1)
> +		;
> +}
> +
>  static int pmu_restart_notify(struct notifier_block *this,
>  		unsigned long code, void *unused)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/9] samsung: pmu: split up SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 12:50 +0100
  [PATCH v4 2/9] ARM: EXYNOS: Fix potential NULL pointer access in  exynos_sys_powerdown_conf Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 12:50 +0100
    Re: [PATCH v4 2/9] ARM: EXYNOS: Fix potential NULL pointer access in  exynos_sys_powerdown_conf Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-12 05:10 +0100
  [PATCH v4 1/9] ARM: EXYNOS: removing redundant code from regs-pmu.h Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 12:50 +0100
  [PATCH v4 5/9] ARM: EXYNOS: split up exynos4 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 13:00 +0100
  [PATCH v4 4/9] ARM: EXYNOS: split up exynos3250 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v4 4/9] ARM: EXYNOS: split up exynos3250 SoC specific PMU  data Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-12 05:30 +0100
  [PATCH v4 6/9] ARM: EXYNOS: split up exynos5250 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 13:00 +0100
  [PATCH v4 8/9] ARM: EXYNOS: rearrange static and non-static functions  of PMU driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v4 8/9] ARM: EXYNOS: rearrange static and non-static  functions of PMU driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-12 05:40 +0100
  [PATCH v4 7/9] ARM: EXYNOS: split up exynos5420 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v4 7/9] ARM: EXYNOS: split up exynos5420 SoC specific PMU  data Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-12 05:40 +0100
  Re: [PATCH v4 3/9] ARM: EXYNOS: Move pmu specific headers under  "linux/soc/samsung" Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-12 05:10 +0100
    RE: [PATCH v4 3/9] ARM: EXYNOS: Move pmu specific headers under  "linux/soc/samsung" Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-13 10:30 +0100
  Re: [PATCH v4 9/9] drivers: soc: Add support for Exynos PMU driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-12 05:40 +0100

csiph-web