Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1267119

Re: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask insted of pci_dma_supported

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask insted of pci_dma_supported
Date 2015-11-11 13:00 +0100
Message-ID <qtCef-2hA-15@gated-at.bofh.it> (permalink)
References <qtzq2-t6-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Can you try the patch below?

diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
index e2afabf..7ccebae 100644
--- a/drivers/net/ethernet/amd/pcnet32.c
+++ b/drivers/net/ethernet/amd/pcnet32.c
@@ -1500,10 +1500,11 @@ pcnet32_probe_pci(struct pci_dev *pdev, const struct pci_device_id *ent)
 		return -ENODEV;
 	}
 
-	if (!pci_set_dma_mask(pdev, PCNET32_DMA_MASK)) {
+	err = pci_set_dma_mask(pdev, PCNET32_DMA_MASK);
+	if (err) {
 		if (pcnet32_debug & NETIF_MSG_PROBE)
 			pr_err("architecture does not support 32bit PCI busmaster DMA\n");
-		return -ENODEV;
+		return err;
 	}
 	if (!request_region(ioaddr, PCNET32_TOTAL_SIZE, "pcnet32_probe_pci")) {
 		if (pcnet32_debug & NETIF_MSG_PROBE)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask insted of  pci_dma_supported 허종만 <jongman.heo@samsung.com> - 2015-11-11 10:00 +0100
  Re: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask  insted of pci_dma_supported Christoph Hellwig <hch@lst.de> - 2015-11-11 13:00 +0100
    Re: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask  insted of pci_dma_supported Don Fry <pcnet32@frontier.com> - 2015-11-16 05:30 +0100

csiph-web