Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267064
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc |
| Date | 2015-11-11 10:50 +0100 |
| Message-ID | <qtAcp-11f-3@gated-at.bofh.it> (permalink) |
| References | <qssgW-5qo-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote: > _rtl88e_fill_dummy fills the array elemets with zeros if necessary. > _rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code is aligned but it doesn't fill up to the end of FW_8188E_SIZE. Why do we even allocate that much memory. Why don't we just allocate: pfwdata = kmalloc(round_up(fwsize, sizeof(u32)), GFP_KERNEL); regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc Ivan Safonov <insafonov@gmail.com> - 2015-11-08 08:10 +0100
Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-11 10:50 +0100
Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc Ivan Safonov <insafonov@gmail.com> - 2015-11-11 11:20 +0100
csiph-web