Re: [PATCH] sched: prevent getting too much vruntime

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched: prevent getting too much vruntime
Date	2015-11-11 10:50 +0100
Message-ID	<qtAcp-11f-11@gated-at.bofh.it> (permalink)
References	<qtzq2-t6-21@gated-at.bofh.it> <qtzT3-Tu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 11, 2015 at 10:26:32AM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 05:50:27PM +0900, byungchul.park@lge.com wrote:
> 
> I've not actually read anything; my brain isn't working right today.
> 
> > +static inline void vruntime_unnormalize(struct cfs_rq *cfs_rq, struct sched_entity *se)
> > +{
> > +	se->vruntime += cfs_rq->min_vruntime;
> > +	if (unlikely((s64)se->vruntime < 0))
> > +		se->vruntime = 0;
> > +}
> 
> But this is broken. This simply _cannot_ be right.
> 
> vruntime very much needs to wrap in u64 space. While regular time in ns
> takes some 584 year to wrap, vruntime is scaled. The fastest vruntime is
> 2/1024 or 512 times faster than normal time. Making it take just over a
> year to wrap around. This will happen.

Then, do you mean it's no problem even if we compare between a vruntime
not wrapped yet and another vruntime already wrapped? I really wonder it.

> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] sched: prevent getting too much vruntime <byungchul.park@lge.com> - 2015-11-11 10:00 +0100
  Re: [PATCH] sched: prevent getting too much vruntime Peter Zijlstra <peterz@infradead.org> - 2015-11-11 10:30 +0100
    Re: [PATCH] sched: prevent getting too much vruntime Byungchul Park <byungchul.park@lge.com> - 2015-11-11 10:50 +0100
      Re: [PATCH] sched: prevent getting too much vruntime Peter Zijlstra <peterz@infradead.org> - 2015-11-11 13:00 +0100
        Re: [PATCH] sched: prevent getting too much vruntime Byungchul Park <byungchul.park@lge.com> - 2015-11-12 06:20 +0100

csiph-web