Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266129

Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle large PAT bit

Show all headers | View raw

On Mon, 2015-11-09 at 16:18 -0700, Toshi Kani wrote:
> On Mon, 2015-11-09 at 17:36 -0500, Boris Ostrovsky wrote:
> > On 11/09/2015 03:47 PM, Kirill A. Shutemov wrote:
> > > On Mon, Nov 09, 2015 at 02:39:31PM -0500, Boris Ostrovsky wrote:
> > > > On 11/09/2015 02:16 PM, Toshi Kani wrote:
 :
> > > > 
> > > > FWIW, it looks like pmd_pfn_mask() inline is causing this. Reverting it
> > > > alone makes this crash go away.
> > > Could you check the patch below?
> > 
> > 
> > I does fix the problem on baremetal, thanks. My 32-bit Xen guests still 
> > fail which I thought was the same issue but now that I looked at it more 
> > carefully it has different signature.
> 
> I do not think Xen is hitting this, but I think page_level_mask() has the same
> issue for a long time.  I will set up 32-bit env on a system with >4GB memory 
> to verify this.

As Kirill explained me in his code review comment for *PAGE_MASK, page_level_mas
k() is fine as it is used for virtual addresses.

-Toshi  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to  handle large PAT bit Toshi Kani <toshi.kani@hpe.com> - 2015-11-09 20:30 +0100
  Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle  large PAT bit Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-09 20:50 +0100
    Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle  large PAT bit "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-11-09 21:50 +0100
      Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle  large PAT bit Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-09 23:40 +0100
        Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to  handle large PAT bit Toshi Kani <toshi.kani@hpe.com> - 2015-11-10 00:30 +0100
          Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to  handle large PAT bit Toshi Kani <toshi.kani@hpe.com> - 2015-11-10 01:50 +0100
  Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle  large PAT bit "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-11-09 21:20 +0100
    Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to  handle large PAT bit Toshi Kani <toshi.kani@hpe.com> - 2015-11-09 22:20 +0100

csiph-web