Re: [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()
Date	2015-11-09 23:40 +0100
Message-ID	<qt3gu-4EA-17@gated-at.bofh.it> (permalink)
References	<qkieK-6nN-5@gated-at.bofh.it> <qkieK-6nN-7@gated-at.bofh.it> <qrZyi-3l7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 06, 2015 at 04:23:56PM -0800, Jeremiah Mahler wrote:
> On Fri, Oct 16, 2015 at 09:40:22PM +0300, Jarkko Sakkinen wrote:
> > Added a new function __compat_only_sysfs_link_group_to_kobj() that adds
> > a symlink from attribute or group to a kobject. This needed for
> > maintaining backwards compatibility with PPI attributes in the TPM
> > driver.

> One problem with this patch is that it adds a bunch of code but none of
> it is used.  So if there is a bug, git bisect will point to a later
> patch instead of this one.

It is fairly standard practice to split cross-subsystem patches like
this, it aids review. git bisect is not a perfect tool.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jeremiah Mahler <jmmahler@gmail.com> - 2015-11-07 01:30 +0100
  Re: [PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-11-09 23:40 +0100

csiph-web