Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1266036
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures |
| Date | 2015-11-09 22:30 +0100 |
| Message-ID | <qt2aL-3vI-29@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <qsNv4-2fT-5@gated-at.bofh.it> <qsV9g-77p-9@gated-at.bofh.it> <qsW5j-7Mk-3@gated-at.bofh.it> <qsY79-QC-33@gated-at.bofh.it> <qsYJQ-15E-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Nov 9, 2015 at 9:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > On Mon, 9 Nov 2015, Emese Revfy wrote: > >> On Mon, 9 Nov 2015 14:50:47 +0000 (GMT) >> Julia Lawall <julia.lawall@lip6.fr> wrote: >> > > Actually, it looks like Emese Revfy is going to merge the GCC plugin >> > > constify stuff sooner rather than later so maybe adding all these consts >> > > isn't going to be needed. >> > >> > Is there any advantage of const over the plugin? The consts are easy to >> > add. >> >> Hi, >> >> I think it's a very good advantage that the plugin constifies automatically >> without regular maintenance (e.g., generate patches with coccinelle, >> send patches to the maintainers every new kernel version). ;) >> But if it doesn't convince you, I did constification by hand (with a coccinelle >> script) some years ago. >> There are too many types that can be const and it took too long to prepare and >> get the maintainers to accept the patches. >> And it never ends as there are always new types that can be const. > > What happens if some structures cannot be made const because there is a > reassignment somewhere? Is there any feedback about the problem? AIUI, for now, we can't make those const (though I would be happy to be corrected). My hope would be to allow reassignment using something like PaX's kernel_open/kernel_close inlines to allow for temporary modification of read-only things (as part of the KERNEXEC feature). -Kees > > julia > >> >> > Does the plugin help for structures that have non-function fields? >> Yes, it does. See __do_const here: >> http://www.openwall.com/lists/kernel-hardening/2015/11/06/11 >> or more about the constify plugin: >> https://pax.grsecurity.net/docs/PaXTeam-H2HC13-PaX-gcc-plugins.pdf >> >> -- >> Emese >> -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] video: constify geode ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2015-11-08 22:50 +0100
Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-08 23:20 +0100
Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-08 23:30 +0100
Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 06:50 +0100
Re: [PATCH] video: constify geode ops structures Joe Perches <joe@perches.com> - 2015-11-09 07:10 +0100
Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 07:50 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 14:40 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 19:20 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Joe Perches <joe@perches.com> - 2015-11-09 19:20 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 15:00 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 16:00 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 17:40 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Emese Revfy <re.emese@gmail.com> - 2015-11-09 18:10 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 18:50 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Kees Cook <keescook@chromium.org> - 2015-11-09 22:30 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 23:00 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures Kees Cook <keescook@chromium.org> - 2015-11-10 00:40 +0100
Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures "PaX Team" <pageexec@freemail.hu> - 2015-11-10 02:40 +0100
Re: [PATCH] video: constify geode ops structures Julia Lawall <julia.lawall@lip6.fr> - 2015-11-10 16:50 +0100
Re: [PATCH] video: constify geode ops structures Kees Cook <keescook@chromium.org> - 2015-11-09 22:30 +0100
Re: [PATCH] video: constify geode ops structures Christoph Hellwig <hch@infradead.org> - 2015-11-10 07:40 +0100
Re: [PATCH] video: constify geode ops structures Kees Cook <keescook@chromium.org> - 2015-11-10 21:40 +0100
Re: [PATCH] video: constify geode ops structures Joe Perches <joe@perches.com> - 2015-11-10 21:50 +0100
Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-10 23:10 +0100
Re: [PATCH] video: constify geode ops structures Joe Perches <joe@perches.com> - 2015-11-10 23:20 +0100
Re: [PATCH] video: constify geode ops structures Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-10 23:40 +0100
Re: [PATCH] video: constify geode ops structures Joe Perches <joe@perches.com> - 2015-11-10 23:50 +0100
csiph-web