Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266017

Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks

Show all headers | View raw

On Mon, 9 Nov 2015 22:12:09 +0100 Jann Horn <jann@thejh.net> wrote:
> 
> > Can we do
> > 
> > #define PTRACE_foo (PTRACE_MODE_READ|PTRACE_MODE_FSCREDS)
> > 
> > to avoid all that?
> 
> Hm. All combinations of the PTRACE_MODE_*CREDS flags with
> PTRACE_MODE_{READ,ATTACH} plus optionally PTRACE_MODE_NOAUDIT
> make sense, I think. So your suggestion would be to create
> four new #defines
> PTRACE_MODE_{READ,ATTACH}_{FSCREDS,REALCREDS} and then let
> callers OR in the PTRACE_MODE_NOAUDIT flag if needed?

If these flag combinations have an identifiable concept behind them then
sure, it makes sense to capture that via a well-chosen identifier.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn <jann@thejh.net> - 2015-11-08 13:20 +0100
  Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access  checks Andrew Morton <akpm@linux-foundation.org> - 2015-11-09 22:00 +0100
    Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Willy Tarreau <w@1wt.eu> - 2015-11-09 22:10 +0100
    Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access  checks Andrew Morton <akpm@linux-foundation.org> - 2015-11-09 22:20 +0100
    Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access  checks Jann Horn <jann@thejh.net> - 2015-11-09 22:20 +0100

csiph-web