Re: [PATCH] tty: audit: Fix audit source

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!feeds.phibee-telecom.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: audit: Fix audit source
Date	Sun, 08 Nov 2015 14:10:01 +0100
Message-ID	<qsxTj-yn-7@gated-at.bofh.it> (permalink)
References	<qsxJD-fn-3@gated-at.bofh.it>
X-Original-To	Peter Hurley <peter@hurleysoftware.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,262,1444719600"; d="gz'50?scan'50,208,50";a="845994057"
MIME-Version	1.0
Content-Type	multipart/mixed; boundary="HlL+5n6rz5pIUxbD"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	fengguang.wu@intel.com
X-Sa-Exim-Scanned	No (on bee); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	538
Organization	linux.* mail to news gateway
X-Original-Cc	kbuild-all@01.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.cz>, linux-kernel@vger.kernel.org, Peter Hurley <peter@hurleysoftware.com>, Laura Abbott <labbott@fedoraproject.org>, Miloslav Trmač <mitr@redhat.com>, stable@vger.kernel.org
X-Original-Date	Sun, 8 Nov 2015 21:01:46 +0800
X-Original-Message-ID	<201511082100.lAxO7dtn%fengguang.wu@intel.com>
X-Original-References	<1446986984-3702-1-git-send-email-peter@hurleysoftware.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1265085

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Peter,

[auto build test WARNING on: v4.3-rc7]
[also build test WARNING on: next-20151106]

url:    https://github.com/0day-ci/linux/commits/Peter-Hurley/tty-audit-Fix-audit-source/20151108-205330
config: x86_64-randconfig-x019-201545 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/tty/n_tty.c: In function 'tty_copy_to_user':
>> drivers/tty/n_tty.c:172:26: warning: passing argument 2 of 'tty_audit_add_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     tty_audit_add_data(tty, from, n, ldata->icanon);
                             ^
   In file included from drivers/tty/n_tty.c:40:0:
   include/linux/tty.h:616:20: note: expected 'unsigned char *' but argument is of type 'const void *'
    static inline void tty_audit_add_data(struct tty_struct *tty,
                       ^

vim +172 drivers/tty/n_tty.c

   156	static inline int tty_put_user(struct tty_struct *tty, unsigned char x,
   157				       unsigned char __user *ptr)
   158	{
   159		struct n_tty_data *ldata = tty->disc_data;
   160	
   161		tty_audit_add_data(tty, &x, 1, ldata->icanon);
   162		return put_user(x, ptr);
   163	}
   164	
   165	static inline int tty_copy_to_user(struct tty_struct *tty,
   166						void __user *to,
   167						const void *from,
   168						unsigned long n)
   169	{
   170		struct n_tty_data *ldata = tty->disc_data;
   171	
 > 172		tty_audit_add_data(tty, from, n, ldata->icanon);
   173		return copy_to_user(to, from, n);
   174	}
   175	
   176	/**
   177	 *	n_tty_kick_worker - start input worker (if required)
   178	 *	@tty: terminal
   179	 *
   180	 *	Re-schedules the flip buffer work if it may have stopped

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Thread

[PATCH] tty: audit: Fix audit source Peter Hurley <peter@hurleysoftware.com> - 2015-11-08 14:00 +0100
  Re: [PATCH] tty: audit: Fix audit source kbuild test robot <lkp@intel.com> - 2015-11-08 14:10 +0100
    Re: [PATCH] tty: audit: Fix audit source Peter Hurley <peter@hurleysoftware.com> - 2015-11-08 14:50 +0100
  [PATCH v2] tty: audit: Fix audit source Peter Hurley <peter@hurleysoftware.com> - 2015-11-08 15:00 +0100
    Re: [PATCH v2] tty: audit: Fix audit source Laura Abbott <labbott@redhat.com> - 2015-11-10 02:50 +0100

csiph-web