Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265057

Re: [PATCH 4.2 108/110] pinctrl: baytrail: Serialize all register access

From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 4.2 108/110] pinctrl: baytrail: Serialize all register access
Date 2015-11-08 10:40 +0100
Message-ID <qsuC7-6MZ-23@gated-at.bofh.it> (permalink)
References <qrURY-d0-7@gated-at.bofh.it> <qrVXJ-V4-45@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, 2015-11-06 at 11:19 -0800, Greg Kroah-Hartman wrote:
> 4.2-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> commit 39ce8150a079e3ae6ed9abf26d7918a558ef7c19 upstream.
> 
> There is a hardware issue in Intel Baytrail where concurrent GPIO register
> access might result reads of 0xffffffff and writes might get dropped
> completely.
> 
> Prevent this from happening by taking the serializing lock in all places
> where it is possible that more than one thread might be accessing the
> hardware concurrently.
[...]

While I have no objection to this, I think a complete fix requires
adding mmiowb() before each spin_unlock.

Ben.

-- 
Ben Hutchings
73.46% of all statistics are made up.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 4.2 108/110] pinctrl: baytrail: Serialize all register access Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-06 21:40 +0100
  Re: [PATCH 4.2 108/110] pinctrl: baytrail: Serialize all register  access Ben Hutchings <ben@decadent.org.uk> - 2015-11-08 10:40 +0100

csiph-web