Re: [BUG, PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [BUG, PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()
Date	2015-11-08 08:50 +0100
Message-ID	<qssTD-5Ef-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <qsg66-5IM-21@gated-at.bofh.it> <qskjo-8jg-11@gated-at.bofh.it> <qskW5-lV-1@gated-at.bofh.it> <qsmlc-15o-9@gated-at.bofh.it> <qsowF-2EK-15@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sat, Nov 07, 2015 at 07:04:04PM -0800, Jeremiah Mahler wrote:
> Jarkko,
> 
> On Sun, Nov 08, 2015 at 02:49:06AM +0200, Jarkko Sakkinen wrote:
> > On Sat, Nov 07, 2015 at 03:11:47PM -0800, Jeremiah Mahler wrote:
> > > Jarkko,
> > > 
> [...]
> > > 
> > > It sounds like you have the problem figured out and have a good fix.
> > > If I can do anything else to help let me know :-)
> > 
> > Turns out that after all the second issue that I described was also
> > because of this patch.
> > 
> > Clean up was not done properly when that function. I revised my fix.
> > 
> > If you want to help, check that the revised patch works I'll add
> > Tested-by to the patch. Thank you!
> > 
> > > -- 
> > > - Jeremiah Mahler
> > 
> > /Jarkko
> 
> I tested the patch (link below) and it works with one small caveat.
> The patch would not apply because line 231 uses list_add_tail_rcu
> instead of list_add_rcu.  I am working from commit 9b774d5cf2d where
> the problem started.  Your repo likely has other changes involved.
> 
> https://github.com/jsakkine/linux-tpmdd/commit/73ea7e0b8045f9610c3274bcefaf89b7a05ee781

Yes, that branch also fix that changes one list_add_rcu() to
list_add_tail_rcu(). I'll add Tested-by to the commit message. Thanks
again for the good work.

> -- 
> - Jeremiah Mahler

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jeremiah Mahler <jmmahler@gmail.com> - 2015-11-07 04:00 +0100
  Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-11-07 12:00 +0100
    Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-11-07 12:50 +0100
      Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jeremiah Mahler <jmmahler@gmail.com> - 2015-11-07 19:10 +0100
        Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-11-07 23:40 +0100
          Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jeremiah Mahler <jmmahler@gmail.com> - 2015-11-08 00:20 +0100
            Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-11-08 01:50 +0100
              Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jeremiah Mahler <jmmahler@gmail.com> - 2015-11-08 04:10 +0100
                Re: [BUG, PATCH 03/10] sysfs: added  __compat_only_sysfs_link_entry_to_kobj() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-11-08 08:50 +0100

csiph-web