Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265639

Re: [PATCH 12/26] Input: synaptics-rmi4: Use generic interrupt handling

Show all headers | View raw

On Fri, Nov 6, 2015 at 12:40 AM, Andrew Duggan <aduggan@synaptics.com> wrote:

> Currently the RMI4 driver expects the device to have a GPIO and manages
> the that GPIO internally. However, this duplicates functionality which
> could be handled by more generic interrupt handling code. Also, some
> RMI devices will not have a GPIO or it won't be accessible to the rmi4
> driver. This patch removes the GPIO code and instead gets the irq passed
> up from the underlying transport (ie i2c-core).
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>

This is much better and should be squashed into the core patch adding
the bus. The other GPIO cruft I was talking about seems to be going
away with this and abstract away things nicely.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 12/26] Input: synaptics-rmi4: Use generic interrupt handling Andrew Duggan <aduggan@synaptics.com> - 2015-11-06 00:50 +0100
  Re: [PATCH 12/26] Input: synaptics-rmi4: Use generic interrupt handling Linus Walleij <linus.walleij@linaro.org> - 2015-11-09 14:10 +0100

csiph-web