Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265634

Re: [PATCH] Input: parkbd - Drop bogus __init from parkbd_allocate_serio()

Show all headers | View raw

On Sat, Nov 07, 2015 at 04:53:23PM +0100, Geert Uytterhoeven wrote:
> WARNING: vmlinux.o(.text+0x1056606): Section mismatch in reference from the function parkbd_attach() to the function .init.text:parkbd_allocate_serio()
> The function parkbd_attach() references
> the function __init parkbd_allocate_serio().
> This is often because parkbd_attach lacks a __init
> annotation or the annotation of parkbd_allocate_serio is wrong.
> 
> Commit 33ca8ab97cbb676d ("Input: parkbd - use parallel port device
> model") dropped the __init attribute from the sole caller of
> parkbd_allocate_serio(), but forgot to remove it from
> parkbd_allocate_serio() itself.
> 
> Fixes: 33ca8ab97cbb676d ("Input: parkbd - use parallel port device model")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

I don't see this with allmodconfig on i386 or on x86_64. How did you get
this warning? But anyway, looking at the code, i did miss attribute.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Input: parkbd - Drop bogus __init from parkbd_allocate_serio() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-08 10:00 +0100
  Re: [PATCH] Input: parkbd - Drop bogus __init from  parkbd_allocate_serio() Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-09 14:10 +0100
    Re: [PATCH] Input: parkbd - Drop bogus __init from parkbd_allocate_serio() Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-09 14:20 +0100
      Re: [PATCH] Input: parkbd - Drop bogus __init from  parkbd_allocate_serio() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-09 18:30 +0100

csiph-web