Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265628

Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed
Date 2015-11-09 14:00 +0100
Message-ID <qsUdc-6vT-13@gated-at.bofh.it> (permalink)
References <qrCim-57c-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Nov 6, 2015 at 12:37 AM, Andrew Duggan <aduggan@synaptics.com> wrote:

> From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Host Notify does not work with neither IRQ nor polling. Allow a RMI4 driver
> to request or not polling depending on the attn_gpio.
>
> When neither the internal IRQ or polling systems are used, the
> transport driver can call rmi_process_interrupt_requests() to
> trigger a process of the alert.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Tested-by: Andrew Duggan <aduggan@synaptics.com>

(...)
> +       } else if (pdata->attn_gpio == RMI_POLLING) {
(...)
> +#define RMI_POLLING    -1

Aeuck ... this thing should be rewritten to use GPIO descriptors
instead of this old number-based stuff.

I'll go in and see if I can take a stab at it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed Andrew Duggan <aduggan@synaptics.com> - 2015-11-06 00:40 +0100
  Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling  when needed Linus Walleij <linus.walleij@linaro.org> - 2015-11-09 14:00 +0100
  Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling  when needed Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-10 00:20 +0100

csiph-web