Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265667

Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support
Date 2015-11-09 14:40 +0100
Message-ID <qsUPU-70f-11@gated-at.bofh.it> (permalink)
References <qrCs2-5az-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <aduggan@synaptics.com> wrote:

> From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> RMI4 Function 0x30 provides support for GPIOs, LEDs and mechanical
> buttons.  In particular, the mechanical button support is used in
> an increasing number of touchpads.
>
> [BT] cured the code to rely only on the unified input node created
> by rmi_driver.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> Signed-off-by: Allie Xiong <axiong@synaptics.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

I see this function driver is not yet adding any gpio_chip or
LEDs class devices, which is fine, we can add that later when
we have something to test. Or is iit using that LED feature
in the input layer that corresponds to caps lock etc?

I don't quite get it I guess :/

But I guess it should also be squashed into the original F30 driver.

Yours,
Linus Waleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Andrew Duggan <aduggan@synaptics.com> - 2015-11-06 00:50 +0100
  Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Linus Walleij <linus.walleij@linaro.org> - 2015-11-09 14:40 +0100
    Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Benjamin Tissoires <benjamin.tissoires@gmail.com> - 2015-11-09 15:10 +0100
      Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Andrew Duggan <aduggan@synaptics.com> - 2015-11-10 00:00 +0100
        Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-10 00:30 +0100
          Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Andrew Duggan <aduggan@synaptics.com> - 2015-11-11 20:20 +0100
            Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Linus Walleij <linus.walleij@linaro.org> - 2015-11-14 12:40 +0100
        Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support Linus Walleij <linus.walleij@linaro.org> - 2015-11-10 10:00 +0100

csiph-web